Skip to content

Conversation

@roomote
Copy link
Contributor

@roomote roomote bot commented Aug 27, 2025

This PR attempts to address Issue #7438 by adding visibility of the current LLM model in the task header interface.

Problem

Users were unable to see which LLM model they were using in the interface, as reported in the critical UX feedback.

Solution

Added model display in the TaskHeader component:

  • Collapsed view: Model name appears next to the token count
  • Expanded view: Dedicated "Model" row in the task details table
  • Added localization support for the "Model" label

Changes

  • Modified webview-ui/src/components/chat/TaskHeader.tsx to display the model ID in both collapsed and expanded states
  • Added "model" translation key to webview-ui/src/i18n/locales/en/chat.json

Testing

  • All existing tests pass
  • Linting and type checks pass

Future Improvements

  • Add translations for other supported languages
  • Add specific test coverage for the model display feature

Fixes #7438

Feedback and guidance are welcome!


Important

Display current LLM model in TaskHeader UI, with localization support, addressing UX feedback.

  • UI Changes:
    • TaskHeader.tsx: Display current LLM model ID next to token count in collapsed view and in a dedicated row in expanded view.
  • Localization:
    • Add "model" translation key to chat.json for localization support.
  • Testing:
    • All existing tests pass.
    • Linting and type checks pass.

This description was created by Ellipsis for 30f792d. You can customize this summary. It will automatically update as commits are pushed.

- Added model display in both collapsed and expanded task header views
- Shows model name next to token count in collapsed view
- Added dedicated Model row in expanded task details table
- Added localization support for "Model" label in chat.json

Fixes #7438
@roomote roomote bot requested review from cte, jr and mrubens as code owners August 27, 2025 00:27
@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. UI/UX UI/UX related or focused labels Aug 27, 2025
Copy link
Contributor Author

@roomote roomote bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewing my own code is like debugging in a mirror - everything looks backwards and I still missed half the bugs.

"collapse": "Collapse task",
"seeMore": "See more",
"seeLess": "See less",
"model": "Model",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This only adds the translation to the English locale. What about our non-English speaking users? All other language files (es, fr, de, ja, ko, zh-CN, etc.) need this "model" key added too, or they'll see missing translation warnings.

You'll need to add the "model" key to all locale files in webview-ui/src/i18n/locales/*/chat.json

const reservedForOutput = maxTokens || 0
const availableSpace = contextWindow - (contextTokens || 0) - reservedForOutput
{/* Model display */}
{modelId && <span className="text-vscode-descriptionForeground opacity-80">{modelId}</span>}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The opacity-80 styling might make the model name less visible, which contradicts the goal of addressing the visibility issue from #7438. Since this is meant to fix a critical UX problem about not being able to see the model, should we make it more prominent?

{t("chat:task.model")}
</th>
<td className="align-top">
<span>{modelId}</span>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Model IDs can be quite long (e.g., "anthropic/claude-3-opus-20240229"). Consider adding a tooltip with the full model name or truncating with ellipsis for better UX when space is limited in the collapsed view.

@hannesrudolph hannesrudolph added the Issue/PR - Triage New issue. Needs quick review to confirm validity and assign labels. label Aug 27, 2025
@daniel-lxs daniel-lxs closed this Aug 27, 2025
@github-project-automation github-project-automation bot moved this from New to Done in Roo Code Roadmap Aug 27, 2025
@github-project-automation github-project-automation bot moved this from Triage to Done in Roo Code Roadmap Aug 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Issue/PR - Triage New issue. Needs quick review to confirm validity and assign labels. size:L This PR changes 100-499 lines, ignoring generated files. UI/UX UI/UX related or focused

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

Critical User Experience Issues with Roo

4 participants